Skip to content

fix: remove alias rigid before calling relate#158792

Open
cordx56 wants to merge 1 commit into
rust-lang:mainfrom
cordx56:fix/issue-158773
Open

fix: remove alias rigid before calling relate#158792
cordx56 wants to merge 1 commit into
rust-lang:mainfrom
cordx56:fix/issue-158773

Conversation

@cordx56

@cordx56 cordx56 commented Jul 5, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown

This PR fixes #158773.
This fix resolves regression from at least nightly 1.96.0, as I checked.

Cause of issue

In the current code, relate(a, b) is called on the type SameTypeModuloInfer, which is outside of the trait resolver.
So the rigid should be removed.

I inserted ty::set_aliases_to_non_rigid before calling relate method and now it works correctly.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 5, 2026
@rustbot

rustbot commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @mati865 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 22 candidates

@cordx56

cordx56 commented Jul 5, 2026

Copy link
Copy Markdown
Author

Hi, @adwinwhite. I found the issue is easily resolved and fixed in this PR.

If you already working on this problem, sorry for taking it without your confirm.
And if you find any problems, I would appreciate any comments.

@cordx56 cordx56 changed the title fix: remove alias regid before calling relate fix: remove alias rigid before calling relate Jul 5, 2026
@cordx56 cordx56 force-pushed the fix/issue-158773 branch from 0123fa1 to f06cf81 Compare July 5, 2026 04:54
@adwinwhite

adwinwhite commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hi, could you check whether the problem can be fixed at the root? Like if there's something that should be normalized but not. set_aliases_to_non_rigid is kinda a hack. See the comments of it.

adwinwhite
adwinwhite reviewed Jul 9, 2026
View reviewed changes
Comment thread tests/ui/traits/next-solver/rigid-alias-in-same-type-modulo-infer-158773.rs
@@ -0,0 +1,17 @@
// Regression test for #158773.
// This test is cited from #158773.
//@ compile-flags: -Znext-solver=globally

@adwinwhite adwinwhite Jul 9, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this flags line at the beginning of the file.
And you don't have to repeat the issue number for three times. One comment to reference it is fine.

nits :>

View changes since the review

@cordx56

cordx56 commented Jul 9, 2026

Copy link
Copy Markdown
Author

Thanks for reviewing! Okay I will check it. But I will do it after my working hours so it will be late…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adwinwhite adwinwhite adwinwhite left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mati865 mati865

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ICE]: No != Yes ( is_rigid_a != is_rigid_b)

4 participants

@cordx56 @rustbot @adwinwhite @mati865